1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Commit graph

1282 commits

Author SHA1 Message Date
Jonah Graham
3caea240a3 Bug 540373: Format some Java files that were missed
Some files which has other cleanups applied meant they needed to be
reformatted again. e.g. the removing of type parameters shortened
some lines of code that meant the wrapping changed.

Change-Id: I68ca09567b9530cc2a085c33923642b6de2ec77b
2018-11-23 13:59:46 +00:00
Jonah Graham
ff75ae80fa Bug 540373: Cleanup: Remove trailing whitespace in properties files
Command used:
# Remove space at eol in comments
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^(#.*)[ \t]+$/\1/' {} +
# Remove space at eol in blank lines
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^[ \t]+$//' {} +
# Replace escaped spaces at eol with unicode
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\ $/\1\\u0020/' {} +
# Replace unescaped spaces at eol with unicode
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\]) $/\1\\u0020/' {} +
# Replace escaped tabs at eol with unicode
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\\t$/\1\\u0009/' {} +
# Replace unescaped tabs at eol with unicode
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\t$/\1\\u0009/' {} +
# Stage all changes
git add -A .
# trim any remaining whitespace and then identify and fixup
# manually
# Only dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/MessagesForDebugVM.properties
# needed this due to missing newline at end of the file
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/[ \t]+$//' {} +

Change-Id: I858f16891fe001f4f7e62d5a4f904146e891cd39
2018-11-23 07:52:26 +00:00
Jonah Graham
b4031b5a8b Bug 540373: Safely remove trailing whitespace from MANIFEST.MF
Change-Id: Iec292561511bc696ab8a7a617e50fbc089b7bff9
2018-11-23 00:42:21 +00:00
Jonah Graham
aa1040a21a Bug 540373: Remove '(non-Javadoc)' comments
These were inserted in the past automatically by Eclipse but
newer tooling makes them redundant.

These were removed by doing a global find/replace on *.java files
using the following regular expression:
\t/\*\n\t \* \(non-Javadoc\)[^/]*/\n

Change-Id: I59d3248020f10934fde1dda5b5a31e20bb188e19
2018-11-22 22:00:29 +00:00
Jonah Graham
eeb3006e27 Bug 540373: Cleanup: Remove redundant semicolons
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant semicolons
and completing the wizard

Change-Id: I3d3175cfdfadec4f815c551d486e42c9f57b80ce
2018-11-22 21:57:01 +00:00
Jonah Graham
caf2292768 Bug 540373: Cleanup: Remove redundant type arguments
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant type arguments
and completing the wizard

Change-Id: Iaecc7010f097b4b1fabd29ccaa34ccb23a716fbf
2018-11-22 21:55:36 +00:00
Jonah Graham
8985c7b63f Bug 540373: Cleanup: Add missing annotations
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Add missing Annotations - and selecting all three types:
 - @Override
 - @Override on interface methods
 - @Deprecated
and completing the wizard

Change-Id: I5d367dacb04327107f25e147edc08efc4eb1c2fe
2018-11-22 21:51:31 +00:00
Jonah Graham
a923614c73 Bug 540373: Cleanup: Organize Imports
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Organize Imports
and completing the wizard

Change-Id: Ia7b305a4c967d0e6f4e8fb8c1041e7028b24006c
2018-11-22 21:47:02 +00:00
Jonah Graham
170e654b47 Bug 540373: Cleanup: Format & Remove trailing whitespace
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Format source code
- Remove trailing white spaces on all lines
and completing the wizard

Change-Id: I63685372c6bcc67719bcf145123bcb72e5b00394
2018-11-22 21:47:02 +00:00
Jonah Graham
35996a5c5c Bug 540373: Standard .settings auto applied
The releng/scripts/apply_jdt_prefs_to_all_projects.sh was run to
copy standard settings to all other projects.

Change-Id: I4436c947d7f0142f56b709e661379c3eb54f666b
2018-11-22 21:47:02 +00:00
Jonah Graham
f70a8b35c1 Bug 540371: Update to EPLv2 using releng/scripts/change_to_eplv2.sh
Change-Id: Ifbb1d5af2a00bd5634dea200320e8c4303ffca6c
2018-11-22 20:31:51 +00:00
Jonah Graham
48d2271a58 Bug 540373: Normalize newlines with .gitattributes
There is also a new script to verify completeness of .gitattributes:
releng/scripts/verify_gitattributes.sh

Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b
2018-11-20 21:20:39 +00:00
Marc-Andre Laperle
7999eab841 Bug 516046 - NPE in AbstractDebugTextHover when hovering over undefined macro
Change-Id: If732a826801f025e929f711fa35a793545d0ed73
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-11-13 21:20:13 -05:00
Karsten Thoms
652602febd Bug 540610 - Add Automatic-Module-Name header
Change-Id: Ia990b24469751050dd9ec8f9b5550804816308b3
Signed-off-by: Karsten Thoms <karsten.thoms@itemis.de>
2018-10-30 15:49:15 +01:00
William Riley
f3ca365140 Bug 540367 - Increment version numbers
Change-Id: I4a355170a7075f0a98ba3c1a5131c235c89b07d2
2018-10-23 11:20:31 -04:00
Alexander Kurtakov
3ebd99eab7 Remove unused private methods.
Change-Id: Ie3c9fa60313d7a14a1f633df2ced698e55dd75ee
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-08 23:22:22 +02:00
Alexander Kurtakov
12681f7807 Remove unnecessary suppress warnings.
Change-Id: I1c3de215d9c4f488309f53eaa4a90a32210994be
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-08 13:03:22 -05:00
Alexander Kurtakov
13f83967c4 Remove unnecessare NON-NLS.
Change-Id: I5ee2ee0c2fe784d1734dd48c653232ba9909f6bd
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
2018-02-08 13:02:21 -05:00
Jeff Johnston
e24a04895a Fix current patch concerning Container launching
- fix CApplicationLaunchShortcut find config method test for
  Container build so we don't ignore valid local launch configs

Change-Id: I4453ce2b26e15c9ec8ad53252e9e539c1268ddd8
2018-01-23 13:20:53 -05:00
Jeff Johnston
746993c9ee Bug 530053 - Launching locally after Container launch doesn't work
- add logic in CApplicationLaunchShortcut find launch configs to
  discard any launch config that has a Docker Connection URI
  attribute

Change-Id: Ieb53f4c89b24cd3fac01bec35eafc8c62748d0b3
2018-01-19 14:37:44 -05:00
Jonah Graham
d4bfa4ac43 Bug 525675: Fix dependency version
The o.e.c.debug.ui uses some internals in o.e.ui.ide that only existed
in Oxygen and greater. Bug 516470, which should be fixed for Photon will
mean these internals can be removed.

Change-Id: If0fbd186a8d6b77a6cb6b8a9d231c784b45cb88d
2017-11-14 22:20:13 +00:00
Jonah Graham
fad069c809 Bug 525675: Delegate opening unknown file types to unknownEditorStrategy
This code enables the Debug view in CDT to take advantage of:
https://www.eclipse.org/eclipse/news/4.6/platform.php#text-editor-selection-strategy

Change-Id: I35e0453ce7ee772aac33ffbce6e66926bbb475e3
2017-11-14 20:57:54 +00:00
Jesper Eskilson
0c11499211 Bug 242705: Fix misaligned breakpoint icon
This commit fixes the "misalignment" of the breakpoint icon by replacing
it with the same icon as JDT uses.

Change-Id: I5a205a095dd37f61774adbf0fc61378ad29fe2bf
Signed-off-by: Jesper Eskilson <jesper.eskilson@iar.com>
2017-11-09 08:42:05 -05:00
Doug Schaefer
5228d19300 UI for adding toolchains for Core Build. New Generic Target Wizard.
Provide a way to add new toolchains. Also start of UI to allow for
reordering them to help with toolchain selection for targets.

New Generic Target Wizard for the new wizard2 extension point for the
Launch Bar Target UI.

Change-Id: I60635ab27dad5b69df72c339337473183dcf711a
2017-09-28 13:42:58 -04:00
Doug Schaefer
c3f3da9f25 Core Build - add support for Generic target
Adapts to LaunchBar's new Build Tab extension.

Change-Id: Icad41a7083f4389a546234d2835a9c4b60fa0eae
2017-09-07 15:52:28 -04:00
Andreas Sewe
18831f4407 Bug 520846 - Use ArrayContentProvider.getInstance() where possible
As ArrayContentProvider is stateless, re-using the global instance
avoids a few allocations.

Change-Id: Ia378195c2c90e35badcf6e2c1938a93877a442e6
Signed-off-by: Andreas Sewe <andreas.sewe@codetrails.com>
2017-08-10 11:36:45 -04:00
Jon Beniston
167a605b57 Bug 257449. Search for any type of launch, not just C.
Change-Id: Ib8ec324aaf3ae1723c6dea53770965b600314203
Signed-off-by: Jon Beniston <jon@beniston.com>
2017-06-26 20:43:58 -04:00
Jonah Graham
cea32dfe7b Bug 516461: use user's/content-type editor selection
This fix applies during debugging:
1) If a user has overridden the default editor to open an IFile with,
ensure that decision is respected by the breakpoints window.
2) If a user has put a breakpoint in an external file, open the same
editor as would be opened by File > Open File

Change-Id: Id32419f1197e3a8eaebf8fad176a884464cbcf85
2017-05-11 13:31:58 +01:00
Jonah Graham
9f4feda520 Bug 516461: Make getEditorId from IDE available
See https://bugs.eclipse.org/bugs/show_bug.cgi?id=516470
This code will be removed one Bug 516470 is resolved and
available.

Change-Id: I0ba4ce121ce94c9ab31b715fbac3c92e61d9c991
2017-05-11 13:25:47 +01:00
Jonah Graham
2f3dbb123a Bug 515296: Create all CSourceNotFound controls unconditionally
When the editor is first opened, if it is not opened on something
that resolves isDebugElement = true, the set of controls to be visible
is different. This change ensures that the same editor can be reused
between isDebugElement = true and isDebugElement = false cases.

Change-Id: I153433de1716c8c8eeffd6ec49d0b1422b04921e
2017-05-09 14:34:25 +01:00
Jonah Graham
fb8e792478 Bug 515296: Collapse empty space when buttons are not visible
With the new "Preferences" button in CSourceNotFoundEditor always
visible, under some conditions (e.g. when no debug info available)
there would be a large gap due to invisible buttons. This change
does a relayout / exclude when the visibility of the buttons
change.

Change-Id: I68ae8665c286eb41f37fa823b3d3168175140ba3
2017-05-09 14:33:05 +01:00
Jonah Graham
c167eeeb1e Bug 515296: Cosmetics.
Change-Id: Ida4c6b477a7fec2d5a5696f456ed5ce993ba6ece
2017-05-09 13:49:35 +01:00
Yannick Mayeur
832f7f5a47 Bug 515296: Changed the message when only Address
When the Source Not Found Editor opens with only an address, the message
is changed, to confuse the user less.

Change-Id: I1dcc9fae80d20975b00d2d356469ddda8c2d8d2b
Signed-off-by: Yannick Mayeur <yannick.mayeur@gmail.com>
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
Also-by: Pierre Sachot <sachot.pierre@laposte.net>
Also-by: Jonah Graham <jonah@kichwacoders.com>
2017-05-09 11:39:06 +01:00
Pierre Sachot
10b1e6e4c7 Bug 515296: New Preferences for Source not found Editor
You now have more precise options for the Source not
Found Editor.

Change-Id: I7391e50c0a9bf7fc712a45d1946e5a24e91c4991
Signed-off-by: Pierre Sachot <sachot.pierre@laposte.net>
Signed-off-by: Yannick Mayeur <yannick.mayeur@gmail.com>
Also-by: Pierre Sachot <sachot.pierre@laposte.net>
Also-by: Yannick Mayeur <yannick.mayeur@gmail.com>
2017-04-28 12:09:18 -04:00
Pierre Sachot
8be69a5985 Bug 515296: Adding choice to not show editor again
We added a checkbox to disable the source not found editor and an option
in preferences for adding it again.

Change-Id: Icc7a21cd14ea81e53517d0b3c420de0927335ed4
Also-by: Yannick Mayeur <yannick.mayeur@gmail.com>
Signed-off-by: Pierre Sachot <sachot.pierre@laposte.net>
2017-04-21 11:24:47 +01:00
Yannick Mayeur
65c9e08d68 Bug 515296: changed the color of the error message
Change-Id: I04990deaef456df125d448d19372dd32c20859f6
Signed-off-by: Yannick Mayeur <yannick.mayeur@gmail.com>
2017-04-20 05:29:53 -04:00
Jonah Graham
546a5a6c91 Bug 515296: Cosmetics.
Change-Id: I25996dc6fe1b4f3f01de4089e6322fd39009ab03
2017-04-20 09:34:11 +01:00
Stephen Flynn
18ce8d099f Bug 510879: Remove requirement for suspended context in Disassembly View
Allow disassembled code to be displayed even while a running thread is
selected.  Switching from a suspended to a live thread does not clear
the view.  To initially get the disassembled code, a suspended context
is required.

Move the check for a frame context to the backend, allowing extenders to
provide custom symbol lookup by overriding
DisassemblyBackendDsf#evaluateAddressExpression.  Overriding this method
to provide custom lookup also allows fetching disassembled code from a
live thread.

Edit:  Make Disassembly message consistent so that prior to selecting a
suspended context the view shows 'No Debug Context'.  After selecting a
suspended context disassembly is shown for all nodes except launch.

Change-Id: I42c54b179b5dacc16f7a5e04a83ddb973ccc6dde
Signed-off-by: Stephen Flynn <stephen.flynn@dell.com>
2017-04-05 15:08:35 -04:00
Marc-Andre Laperle
0046099052 releng: Make use of Tycho POM-less functionality
This removes a lot of pom.xml from the source tree. This is using the
"POM-less" Tycho functionality.
See
https://wiki.eclipse.org/Tycho/Release_Notes/0.24#POM-less_Tycho_builds

One advantage of this is that you do not need to update the version in
the pom.xml when you change it in the MANIFEST.MF because the pom.xml is
automatically generated. This also reduces a lot of the duplicated
information and pom.xml repetition.

- Maven 3.3 and up is required.
- Only eclipse-plugins and eclipse-features can be pom-less.
Repositories, target and others still have pom.xml.
- New parent poms are added because a parent is necessary directly one
level above the plug-in/feature that will have its pom generated
- Some test plug-ins had to be renamed .test -> .tests because it's
required so that it detects that it's a test plug-in
- Some suites were renamed so that they all use the same consistent name
"AutomatedIntegrationSuite"
- Profiles were added for the more common test configurations. They are
activated by the presence of simple .properties files that only serve to
activate the correct profile. The profiles:
  - One for UI tests (UI present and start in UI thread)
  - One for SWTBot tests (UI present and do not start in UI thread)
Other test plug-ins that are too different are kept intact and still
have
a pom.xml
- Fragments are kept intact since they all have different target
platform configurations

Change-Id: I9d73380eb766f547830c552daf08053a30b1845c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
2017-02-13 23:19:56 -04:00
Alvaro Sanchez-Leon
d06db08a30 Bug 506073 - Support address "range" when adding a memory watchpoint
Change-Id: If3130ed52df95b0481d95477727fc2f419251ade
Signed-off-by: Alvaro Sanchez-Leon <alvsan09@gmail.com>
2017-02-07 13:52:25 -04:00
Marc Dumais
86189eeb86 Bug 510924 - Alt+Enter on breakpoint shows incomplete properties dialog
When using the "Alt-Enter" shortcut with a breakpoint selected, the
properties dialog that is created is missing some fields. This seems to
be caused by the fact that the dialog, when summoned in this way, is
created using a wrong context: an ICLineBreakpoint instead of the
expected CBreakpointContext. That context is then used to fetch
properties from the store, which fails.

This is a naive fix that attempts to work around this by creating a
proper context from the breakpoint.

Change-Id: I2b7c86965d09898dd1cd7eeb3c3f704bb2995e20
2017-02-07 10:55:19 -04:00
Jonah Graham
e93de453f8 Bug 509897: Use View Management for Debugger Console
Change-Id: I509d3b5679e2ab236f8cd09b122ffae603a5fc51
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
2017-02-06 06:15:19 -05:00
Marc-Andre Laperle
02a04cebad Fix API errors with Eclipse 4.7
- Adding default methods can now be ignored
- Adding fields is now an error but we probably want to ignore this
because it is quite restrictive

Change-Id: Ie57c69f54c64e4913d1498b02e86d00c93f8101a
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
2017-01-30 14:11:36 -04:00
Bruno Medeiros
5c93171cbc Bug 511029 - Debug views become permanently pinned...
... if they are closed and reopened whilst pinned.

This was because IPartListener2 was being removed before #partClosed()
was called.

Change-Id: I16de016387131b775237b5d61639bb32107231fe
Signed-off-by: Bruno Medeiros <bruno.do.medeiros@gmail.com>
2017-01-30 12:41:59 -05:00
Marc Khouzam
6480a154ef Bug 508543 - Reverse Bp Action doesn't display type properly for editing
The value returned by IBreakpointAction#getTypeName() must match the
value provided in the plugin.xml file for that same action.  The two
names are compared in ActionDialog.createDialogArea() to know if the 
proper action has been found.  This is a fragile technique, that should 
eventually be improved.  For now, we just fix the current problem.

Change-Id: I70fd8b90fc680d3a5d55a95bdd5193d382b6c6f2
2017-01-23 12:42:09 -05:00
Marc Khouzam
bfea9deb90 Bug 303808: Example of ConsolePageParticipant for Debugger Console
This commit also enables a richer set of enablement checks when
contributing ConsolePageParticipants to the Debugger Console view.

Change-Id: I34aa010fd9cfa91f24781e2bef5ba41b9525eab0
2017-01-19 15:40:47 -05:00
Marc Khouzam
d780df14c2 Bug 303808: Make it easier to extend Debugger Console pages
To perform actions on the GdbFullCliConsole, it is important to provide
access to the terminal widget.  This patch adds the new method
GdbFullCliConsolePage#getTerminalViewControl() to give access to the
ITerminalViewControl.

Also, to be consistent with the platform's ConsoleView, this patch also
adds the same groups in the toolbar.  Namely
IConsoleConstants.LAUNCH_GROUP and IConsoleConstants.OUTPUT_GROUP.
Extenders can use these groups to add their buttons to the Debugger
Console view.

Change-Id: I217ce54ada63796de776c6b4cb6b925c3feb7eea
2017-01-19 11:02:17 -04:00
Stephen Flynn
576d41fe69 Bug 303808 Allow page participants for GdbFullCliConsole.
This commit borrows code from ConsoleView and ConsoleManager to allow
adding page participants to GdbFullCliConsole.

Change-Id: I4b99600bc4fba3bfecb9a4822f94e2be7d3aa601
Signed-off-by: Stephen Flynn <stephen.flynn@dell.com>
2017-01-19 10:01:09 -05:00
Alvaro Sanchez-Leon
028eb67a17 Bug 509895 - GdbBasicCliConsole left running after platform shutdown
when launch fails

Change-Id: I5879f5ed770e63c11077e091f18c5766b243bd88
2017-01-17 12:49:15 -04:00
Marc Khouzam
bed0869293 Typo in error message
Change-Id: Icb470bfadd25ae37fcfacece90ec49b4423f88f0
2017-01-14 08:17:49 -05:00