A space must be forced in this special case even if preferences
say something different.
Change-Id: Ie43b988139913f87590f4f1460d28e79f9bd7ef8
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Refresh the toolbar buttons after registering the command handlers, to
make sure that they are active.
Change-Id: Ibee71a54fff7be0325257d25247e4e73f8b09b2e
Task-Url: https://bugs.eclipse.org/bugs/show_bug.cgi?id=544535
Signed-off-by: Felix Morgner <fmorgner@hsr.ch>
Fix a couple of exceptions in formatter flow during operations on
template id in macro.
Change-Id: I768c29e1bd24b1336423b298a22b4016eb96e9c3
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Not active regions of code may not be formatted.
Change-Id: I3796bd84bf4101cec55ef9f35f9703e8bc46092e
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
parenthesized expressions in return
This patchset fixes 520117 and adjusts the value category of expressions
of kind E1.E2 to be standard (DR616) compliant.
Change-Id: I9a5cde805f2d0b39a2d263dbc3dcbefd3ba21930
Signed-off-by: Felix Morgner <fmorgner@hsr.ch>
- Return ProblemBinding if conversion from init list failed
- In conversion: don't allow implicit conversion with explicit ctor
Change-Id: I3145b89df778a035ced9999aff4d8a4164eac17f
Signed-off-by: Hannes Vogt <hannes@havogt.de>
The ConsoleOutputStream method added in 6e1b9b4 must be overridden here,
otherwise text sent to it does not appear along with the other console
output.
Change-Id: I1a3803ffb8962140537b877f0df328a4037b4dfb
Signed-off-by: Christian Walther <walther@indel.ch>
The original fix (a733900) only fixed part of the problem: It worked for
the case where a complete CExternalSetting was removed and replaced by a
different one, but not in the case where individual entries from a
CExternalSetting were moved to a different one, but others remained
(and, in both cases, the two CExternalSettings applied to the same
ICLanguageSetting).
This commit
- adds a test for the additional condition, which would previously fail
- reverts the previous fix, which is made redundant by the new one
- fixes both cases by applying removals before additions with
ICSettingEntry granularity per ICLanguageSetting rather than for whole
CExternalSettings.
Change-Id: I1b1ee7443b83189c29e458eef12be9cad6b3965d
Signed-off-by: Christian Walther <walther@indel.ch>
- As of [temp.func.order] p5 only parameters for which there are explicit
arguments should be considered.
- Implement [temp.deduct.partial] p11 (resolution of DR1395).
Change-Id: I56262229a6fe4717c22aac814aa9ea42eb37a10d
Signed-off-by: Hannes Vogt <hannes@havogt.de>
Alias templates can be instantiated with dependent arguments, which
can themselves contain a pack expansion, so we need to take care
that pack expansion expressions are instantiated correctly.
This was previously fixed for pack expansions of types and template
arguments in bug 486971.
The patch also fixes a bug in CPPTypedef.getType() where alias
declarations weren't handled correctly. (This bug would only occur
during debugging as normally the type would be computed via setType().
Change-Id: Ie70a923fc9dd0f177b7bfb429b8f1387966b416d
instantiateCommaSeparatedSubexpressions() is a clunky name, and in C++17
(with fold expressions) the function will no longer be limited to comma-
separated expressions.
Change-Id: Id242f58bb291e79cefe2b28db12dbde4bafba4ed
Take number of explicitly passed arguments into account.
Change-Id: If85f072d8b18f3fd1ca28f3c5688e864b0ffb4cd
Signed-off-by: Hannes Vogt <hannes@havogt.de>
The previous alignment of all the warnings/ignores
led to too many warnings that weren't there before. This
commit relaxes them a bit.
The core/org.eclipse.cdt.core/.settings/org.eclipse.jdt.core.prefs
is still the "master" copy, with
releng/scripts/check_code_cleanliness.sh containing the
exceptions that apply to test plug-ins.
Change-Id: Ibd4e31ade0b42b31e7cbe5a94f06c6fc15183a56
Some files which has other cleanups applied meant they needed to be
reformatted again. e.g. the removing of type parameters shortened
some lines of code that meant the wrapping changed.
Change-Id: I68ca09567b9530cc2a085c33923642b6de2ec77b
Command used:
# Remove space at eol in comments
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^(#.*)[ \t]+$/\1/' {} +
# Remove space at eol in blank lines
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^[ \t]+$//' {} +
# Replace escaped spaces at eol with unicode
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\ $/\1\\u0020/' {} +
# Replace unescaped spaces at eol with unicode
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\]) $/\1\\u0020/' {} +
# Replace escaped tabs at eol with unicode
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\\t$/\1\\u0009/' {} +
# Replace unescaped tabs at eol with unicode
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\t$/\1\\u0009/' {} +
# Stage all changes
git add -A .
# trim any remaining whitespace and then identify and fixup
# manually
# Only dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/MessagesForDebugVM.properties
# needed this due to missing newline at end of the file
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/[ \t]+$//' {} +
Change-Id: I858f16891fe001f4f7e62d5a4f904146e891cd39
These were inserted in the past automatically by Eclipse but
newer tooling makes them redundant.
These were removed by doing a global find/replace on *.java files
using the following regular expression:
\t/\*\n\t \* \(non-Javadoc\)[^/]*/\n
Change-Id: I59d3248020f10934fde1dda5b5a31e20bb188e19
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant semicolons
and completing the wizard
Change-Id: I3d3175cfdfadec4f815c551d486e42c9f57b80ce
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant type arguments
and completing the wizard
Change-Id: Iaecc7010f097b4b1fabd29ccaa34ccb23a716fbf
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove unnecessary casts
and completing the wizard
Change-Id: I287d4066b12fc19d7f73a016e11c9405abb4ceb9
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Add missing Annotations - and selecting all three types:
- @Override
- @Override on interface methods
- @Deprecated
and completing the wizard
Change-Id: I5d367dacb04327107f25e147edc08efc4eb1c2fe
