the rest of Eclipse now uses UTF-8 as default encoding.
The tm.terminal code reverts to null when the encoding
begins with "Default" and this leads to UTF-8 being
selected from Charset.defaultEncoding instead of ISO-8859
when the displayed default value is selected.
Co-authored-by: Philipp SALZGEBER <philipp.salzgeber@bachmann.info>
Beta versions of maven plugins are omitted from this
upgrade.
A new version of Tycho brings in an update ECJ which means some
of the class files are different, hence the need to bump versions
of bundles too.
A new calendar year brings an update to Copyrights
* remove invalid tycho resolver config (not valid since many versions)
* fix PMD plugin configuration (config attribute was renamed in 3.18)
* remove duplicate versions already managed in pluginManagement section
* fix indentation
* move all not yet configured versions into pluginManagement of the
parent module to avoid further duplication
* consume the target platform as file, not as maven artifact (this
simplifies building a single module A LOT)
* remove invalid tycho-source-plugin configuration
* disable tycho consumer POM generation (not needed here, and avoids a
warning in each module)
* remove prerequisites. that's for maven plugins only, and this POM
already contains the better suited similar maven enforcer rule
* enforce UTF-8 for javadoc generation (the build fails on Windows
otherwise, trying to read some Japanese? characters with the Windows
default encoding)
When a more complete implementation of ANSI Escape sequence for
renaming terminal titles was added in
[CDT 10.2](https://github.com/eclipse-cdt/cdt/blob/main/NewAndNoteworthy/CDT-10.2.md#rename-terminal-tab)
it caused a regression in use cases where extenders of the terminal
wanted to retain control of the terminal's title.
This commit adds a new flag that will prevent the title of the
terminal tab from being updated from ANSI escape sequences.
Fixes#494
Fixes cases that cause stack trace like this when opening terminal
connection dialog and selecting ssh type:
```java
!ENTRY org.eclipse.ui.ide 4 4 2023-04-13 15:57:20.632
!MESSAGE Not properly disposed SWT resource
!STACK 0
java.lang.Error: SWT Resource was not properly disposed
at org.eclipse.swt.graphics.Resource.initNonDisposeTracking(Resource.java:172)
at org.eclipse.swt.graphics.Resource.<init>(Resource.java:120)
at org.eclipse.swt.graphics.Image.<init>(Image.java:605)
at org.eclipse.jface.resource.URLImageDescriptor.createImage(URLImageDescriptor.java:300)
at org.eclipse.jface.resource.DeferredImageDescriptor.createImage(DeferredImageDescriptor.java:85)
at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:290)
at org.eclipse.jface.resource.ImageDescriptor.createImage(ImageDescriptor.java:268)
at org.eclipse.tm.terminal.view.ui.panels.AbstractExtendedConfigurationPanel.createHostsUI(AbstractExtendedConfigurationPanel.java:400)
at org.eclipse.tm.terminal.connector.ssh.controls.SshWizardConfigurationPanel.setupPanel(SshWizardConfigurationPanel.java:79)
at org.eclipse.tm.terminal.view.ui.internal.dialogs.LaunchTerminalSettingsDialog$SettingsPanelControl.showConfigurationPanel(LaunchTerminalSettingsDialog.java:124)
at org.eclipse.tm.terminal.view.ui.internal.dialogs.LaunchTerminalSettingsDialog$1.widgetSelected(LaunchTerminalSettingsDialog.java:317)
```
Warning in build.properties will be errors when they run
in the tycho build, like this:
```
Error: Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:2.7.5:package-plugin
(default-package-plugin) on project org.eclipse.cdt.core.tests:
/home/runner/work/cdt/cdt/core/org.eclipse.cdt.core.tests/build.properties:
bin.includes value(s) [test.xml] do not match any files. -> [Help 1]
```
So make them errors in the workspace so that the issue is
detected before push.
Some build.properties issues don't affect the build, but
are still indicative of a problem.
This mostly is using diamond operator, but includes
adding missing @Override and organizing imports and
applying formatting improvements in the JDT formatter.
Change-Id: Id91cbff33b0a039cc5121945ffbc407ecba45866
The CDT Cleanup profile had a bunch of extra cleanups applied to it, this
prevents running the CDT cleanup profile manually to simulate running the
save actions on all Java files
Change-Id: Iad491e1258a4ba90d81d1457ea0f6779e3663e38
All the about.html files are updated, so every bundle that hasn't
already had a bump in 10.7 needs one now
Change-Id: I6143d2fbe77a58a3a6d2f4a226d96087117f9ac1
Newer Tycho has a new feature that adds an extra header (Bundle-License)
to every plug-in. This commit includes omitting this new feature
rather than bumping every single version of every bundle in CDT.
See https://www.eclipse.org/tycho/sitedocs/tycho-packaging-plugin/package-plugin-mojo.html#deriveHeaderFromProject
Bundles have version bumps due to newer Tycho including newer
JDT compiler which leads to classfile differences.
Change-Id: Id536d75a92a30582418324e27d74008869f7dd3a
If the return code is non-zero wsl may have failed in someway, with
recent changes in Windows, wsl.exe is present even when wsl is not
installed. In that case wsl.exe is a dummy that can be used to install
wsl.
Change-Id: I83af60623084e1364d16c3a1739bc4f6a25ac3a9
There is no need to spawn the WSL detect job for other platforms than
Windows.
Contributed by STMicroelectronics
Change-Id: I85256a9f6a4f5e9e9276458ba67e2f6adf02afa7
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
In certain scenarios, the WSL detect job is not launched directly. As
the join() method returns early for suspended jobs, the result list is
read too early and causing NPE.
This was deteced while running the JUnit tests.
Contributed by STMicroelectronics
Change-Id: I8a013cf83be26e8f8bee38fd2e7a4557eb1a57ab
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
This simplifies error handling as once you have a Charset you don't
have to worry about whether or not an UnsupportedEncodingException can
be thrown anymore. In addition it is a little easier on type safety.
Change-Id: I4292878a7c621f9d05fdb98f5c26a0ae8bfec062
The PTY, in case of ConPTY, operates always in UTF-8. This is suggested
back to the user with a decorated combo if they try to change the default.
Change-Id: Iaf4c13e256ea7ee3469eecab4a0ec3df1ceb19a4
In Bug 466650, the git bash detector was removed from startup to reduce
overhead on startup. Later during a rewrite it was added back in under
a different code path for Bug 473107. In the context of Bug 573712
which is going to add more detectors that may do much more work on
a full load, reduce the amount of work needed to do the presence check.
Change-Id: If1ae3f12ec51b1edc2d419f0efd89fed81a7b56e
The code was not very extensible and the main purpose of the bug
is to add additional detectors. This first commit refactors
the code to make that easier, and to provide a platform for
what could become an extension point.
Change-Id: I5ce514eda11f2573098d6e16663e324954da961b
There are lots of bugs in WinPTY, while upgrading WinPTY would
resolve some of them, there are others that are unresolvable. See
https://devblogs.microsoft.com/commandline/windows-command-line-introducing-the-windows-pseudo-console-conpty/
for a backgrounder on the general subject.
In this first version ConPTY won't be enabled by default, it requires
system property
org.eclipse.cdt.core.conpty_enabled=true
to be set. i.e. start Eclipse with:
-vmargs -Dorg.eclipse.cdt.core.conpty_enabled=true
In a future version the default will change to on if available,
so to force it off use:
org.eclipse.cdt.core.conpty_enabled=false
Change-Id: Ib2df0095027c23f20daa6aa044d9e5f0b0443164
The handling of ssecondary ids was problematic, special cases were
not well documented and depending on code paths, a secondary ID
of null would mean different things.
This commit fixes that documentation, defines shared constants, and
fixes the logic so secondary id dispayed terminals restore to the
correct location on restart.
Change-Id: Ia87b64f735a37d505e1a5a7b7a4a8e210dfb8c1e
- hover with ctrl+mouse underlines word under cursor
- ctrl-click tries to open the word:
- if a relative path (not starting with /) a full path is
obtained by prepending the shell cwd
- if the fullpath maps to a workspace file, it is opened
- otherwise open the OpenResource dialog with the word as
filter text
- if there is line/column information (separated by colons)
then the opened editor jumps to that line
- http and https words are opened in a browser window
Change-Id: I3f46accbf1eac6743d7b0c3b34bf30ac5e7523bb
Signed-off-by: Fabrizio Iannetti <fabrizio.iannetti@gmail.com>
Also-by: Jonah Graham <jonah@kichwacoders.com>
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
All the hard work had been done before, simply no one had actually
added the bit of code to update the title based on the listener.
Change-Id: Icdbc7b9b0a9b8fccf7d4eddf8d20674e50e0a170
New action to temporarily invert the terminal colors,
the preference setting is not altered by this action.
Only the active terminal is affected.
Change-Id: Idc01163838539c2ba5699556951c1742bbf07ad6
Signed-off-by: Fabrizio Iannetti <fabrizio.iannetti@gmail.com>
This change adds an extra activity for the TM terminal main toolbar
contribution. This allows applications to disable the contribution
without disabling the rest of TM terminal functionality.
With this change, disabling of the TM terminal main toolbar button can
be done with a product customization file containing the line:
org.eclipse.ui.workbench/UIActivities.org.eclipse.tm.terminal.view.ui.activity.maintoolbar=false
The product customization file is specified to Eclipse arguments:
-pluginCustomization /some/path/plugin_customization.ini
Change-Id: Id1c34616f4f2a0ac77edbfe201c1db095f9ce7b8
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
Version changes are all to refect non-API changes (micro version)
Change-Id: I372aa2671a4c7f5c765a42156d3f639b8eaff680
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
The existing code had the assumption that >= 1 connector was installed
in the IDE. It is difficult to configure the IDE with no connectors as
the base terminal feature includes connectors, but it is technically
possible. So in that case display a simple error message and avoid
a hidden error (and stack trace to log).
Change-Id: Id17a1e5bff9aec251aa6f7fe6ff4e96cd2a01564
