Fixed by getting rid of legacy code for opening a master pty, and
copying the related code from org.eclipse.cdt.core.linux instead.
Only getpt() had to be replaced by posix_openpt(). Compiled on
OSX 10.12 - tested on MacOSX 10.8 and 10.13 beta 7 (64-bit each).
Change-Id: Idade001aed41abafc0d500695a4b51179bb9b738
Signed-off-by: Martin Oberhuber <mober.at+eclipse@gmail.com>
(cherry picked from commit a0ab38124c)
Fixed by copying code from org.eclipse.cdt.core.linux that
contains the fix from bug 119387 : set the process group by
calling setpgid() when forking a process, and use killpg() for
killing the entire process group on termination.
This also aligns MacOS code fully with Linux code. Tested on
MacOSX 10.8 and 10.13 beta. Binaries will be submitted with the
related fix for bug 519886.
Change-Id: I87df87caa88cff60b4d9eee2252252234d1a4f84
Signed-off-by: Martin Oberhuber <mober.at+eclipse@gmail.com>
(cherry picked from commit 1019030e74)
This is a partial revert of e49517eb7c.
This revert prevents an otherwise unnecessary API version increment.
As e49517e added the correct version dependency from
org.eclipse.cdt.dsf.gdb to org.eclipse.cdt.core.native, which was the
true dependency, we don't have to increase the dependency on the
re-exported version within org.eclipse.cdt.core. Because
org.eclipse.cdt.core.native is a singleton and only the 5.10 version of
org.eclipse.cdt.core.native will satisfy the dependency where it is
needed in dsf-gdb, this solution guarantees correct wiring up.
Change-Id: I23b32480550fee33a4e156a91df12ac7720d8dc3
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
This also fixes some ClassCastExceptions caused by types which
implemented ICPPASTInitializerClause but not ICPPEvaluationOwner.
Change-Id: Ie624865ebe476fe760dc28e02b6aef8a43b4c621
Previously, the arguments shared the color of the template-name.
Now, the arguments get their own colors.
Change-Id: I27af4146717a19095f1ac22188eedb8a71d9466c
The set was moved to EvalUtil.getVariableValue() in bug 508254, but this
left some paths unprotected. This restores the set to
CPPVariable.getInitialValue() (while keeping the EvalUtil one too).
Change-Id: I4a579720f4bc23d41e50c484649a73c29698373d
When checking whether gathering the build output from a
CBuildConfiguration, if a binary is a shared library and is an
ELF file, dig deeper and see if it has an INTERP section in the
program header. That tells us it's actually a PIE executable and
add it to the list.
As a rider to this bill, improve the error message when a Qt install
can't be found for a given toolchain/target.
Change-Id: I8fd0bf2d204e9425b02916d7b17f4309a5ad9dd5
The env var operation processer always turned the resulting operation
into a replace, even if it was two prepends. That kills the actual
prepend operation. In this case, keep it as a prepend. Also fix the
append case this way.
Unfortunately this is still broken in other multiple operation
cases, like appending then prepending.
Change-Id: Ib158317f16d025a479201745159a2aa3c1335e25
Added catch all condition to ConditionalExpression type evaluation where
both positive and negative types are the same.
Change-Id: I990b502dfce8ef71c753ac188e072de312b7ea9f
Signed-off-by: Joseph Henry <joseph.henry@sas.com>
This is mostly to mitigate the effects of a bug in ProjectionViewer
(bug 509559). See the discussion in bug 507138 for details.
Change-Id: Icf36b54d6a11892f02214a168ef1c9c284478710