- use of CommandLaunchManager requires higher version of cdt.core
than Autotools specified so up to 6.5.0
Change-Id: I315e69defeee9d7d1e6c016edff2d96013fe13e9
- bump up minimum org.eclipse.cdt.core needed for
org.eclipse.cdt.docker.launcher plug-in so that
ICBuildConfigurationManager2 interface is available
Change-Id: I5e77e7b43bdea1f0b59c79fcdfced7c162b64e9a
- modify ContainerGCCToolChainProvider.init so that the
CBuildConfigurationManager.recheckConfigs() call is done
within a separate job so the init() call will return
without causing deadlock
- do the same for ContainerTargetTypeProvider
- modify CBuildConfigurationManager initProviders() method to
be synchronized
Change-Id: I4ca9371fb340887233872b6d315621a24450fb2b
(cherry picked from commit c9eee479b4)
Builds upon https://git.eclipse.org/r/#/c/92129/ but also uses the hints
to only read the file if necessary. I further reverted some of
the changes done with the patch for 'Bug 510987 - Properly support PIE
executables as build output' since the binary will now be seen as an
executable anyway.
Change-Id: I075fef67f3b101ddbc64786dcbc2ca41cc114e25
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
Backport to the 9.5 branch, including adding an API filter to allow
adding a new keyword and token type.
Change-Id: I9789268dee320ab95aee60c30d8e1867bd0dda53
- add synchronized keyword to the various scanner info collecting
methods in ContainerGCCToolChain
Change-Id: I476e0c191379621d5ca8ef266c8590a0954ab4a5
- don't reset setting in shutdown() method as this clears the
property prematurely for meson and cmake projects
Change-Id: I2dd2467427d00aeade335319ec2ceec9f6d7168d
Turns off doclint for Java 1.8 and greater because the javadocs are
incomplete and won't build otherwise.
Some files also had encoding issues with some characters which caused
the javadoc build to fail, these characters have been replaced.
Change-Id: I04690644bec6d7c3219cb0438cb3db6593fefd3a
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
- fix MesonPropertyPage logic concerning a configured meson project
- for possible values, add "-" and "/" as valid characters
- in state flow, don't just wait for blank lines, an option
header can occur in the middle of a group or a new option group
name can also occur
Change-Id: I2c6c8f9fb15db0425f03e422b20b58ace5234fd4
(cherry picked from commit ac81db720c)
- The commands are launched directly instead of using the shell
(/bin/sh) which is not available on Windows.
Change-Id: I5f8d99a04da1c860bcd37d138103a1bd4e501547
Signed-off-by: François Godin <copelnug@gmail.com>
(cherry picked from commit 0b2053dcb2)
- apply patch submitted by duh-sa-sekirom@hotmail.com
- in GCCToolChain join the threads that do include path and macro
searches before waiting for process so as to prevent a
ConcurrentModificationException
Change-Id: Iefe6f013007b7bbf00117b5295b5e27489a72834
(cherry picked from commit e0c656d2e0)
- add a new IToolChain property "cdt.needScannerRefresh" that is
set if scanner info needs to be refreshed
- for a Container build, turn the property on in ContainerGCCToolChain
startBuildProcess() if the Container headers for the toolchain's
have been deleted
- in CBuildConfiguration processLine(), look for the toolchain
property when looking to see if scannerinfo should be calculated
- in CBuildConfiguration, turn the toolchain property off in
shutdown()
Change-Id: I67a3537d1e2967dc15b66a1c37abda1ae8f78bff
- it seems that fetching the active configuration for a project
using an ICConfigurationDescription is time-consuming
- the active configuration is sought in ContainerCommandLauncherFactory
to get the optional build properties and thus we can figure out
if the active configuration has enabled container build or not
- see if we are given a CConfigurationDescriptionCache and it
contains a BuildConfigurationData element which allows us to
get an IConfiguration without creating a new one, serializing
it etc.. which is adding to the time taken
Change-Id: I8973f1707a602a73fc5ac751f12a1e8dbd549aab
(cherry picked from commit a394557c60)C
- fix GCCToolChain and ContainerGCCToolChain to not blindly
take the first token in the command string when processing
scannerinfo; if it is "ccache", take the second token instead
Change-Id: I4b2b7dfaccae6f3ec968bbe4217c57994ad71963
(cherry picked from commit a5ed8ea2a4)
We were not handling JSON parse errors when loading the scanner info
cache files which causes havoc at index time.
Change-Id: I3a4ee6424134fe756543e4429e9e97b911cda99e
- fix ContainerTargetTypeProvider changeEvent() to start a Job and
return immediately so it will not cause a DockerConnection
to be held in multi-threading
- move the DockerConnectionManager addConnectionListener call
to end of init() method so the fetching of images won't cause
a notification event to occur
- at end of init(), call CBuildConfigurationManager.recheckConfigs()
to make sure any disabled configuration due to a missing
IDockerConnection is now put in the configs master list and
removed from the noconfigs list
- make similar changes to ContainerGCCToolChainProvider
Change-Id: Idc120d613b99ec365522f5e7bf5da82d1b362425
(cherry picked from commit 2bcd06f097)
We weren't dealting with relative include paths returned from
the call to gcc -E properly. Resolves them against the build
directory before checking if their a directory. Results in them
added.
Tested with ESP-IDF's feature/cmake branch.
Change-Id: I1e2583e03cce6380ee4382146b177978c9c81806
AttributeWriter.writeGCCAttributeSpecifier()
* Added test to reproduce initial issue.
Change-Id: I72e60fb2244b7d40492bfcdeaa58a8707c39e277
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
(cherry picked from commit 4e4e010e33)
Includes reverting 851295e821:
[releng] work around Tycho issues of obtaining *.jre.javase [10.0.0]
Change-Id: I1d49b519ba111e48545ef37c991859dfa68960cd
The original implementation used plain-text string manipulation of the
IDocument. This changeset changes the implementation to make use of the
ASTRewrite infrastructure, which automatically honors the const
placement setting.
Change-Id: Ib5ae9381b93ca8ab4d1ad3e16b1c3c8b1ec62d78
Signed-off-by: Felix Morgner <fmorgner@hsr.ch>
Fix and test
Change-Id: I14088e69aed829940fb1e9f5197dedf18d9bb7a5
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
- Launch bar is usually expecting a LaunchConfigurationTargeted
Delegate which calculates the binary but Container build
uses the ContainerLaunchConfigurationDelegate which expects
the program name, working dir, connection, and image id
set up as ILaunchConfiguration attributes
- modify ContainerLaunchConfigurationDelegate to add
finalLaunchCheck method which can verify if the launch
config attributes are set up and if not, set them from
the build config (since this is post-build)
- fix getImageName() in CoreBuildContainerLaunchConfigProvider
to use toolchain attributes
Change-Id: Iad6cc26928c33e964650b99844e065df8653858f
Fix and test
Change-Id: I785ecfd0715f1fa8ff86b87bd01d16ac6d5d5da2
Signed-off-by: Hansruedi Patzen <hansruedi.patzen@hsr.ch>
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
Guard against NULL oldValues, which is legitimate, in which case use an
empty Map.
Change-Id: I78ac252d3e91d431340320719cb57b32145813f0
Signed-off-by: John Moule <evil_bandit_betamax@yahoo.co.uk>
The output of the call to gcc to pick out the defines and include paths
produces them on different streams, defines on stdout and paths on
stderr. Separate the scanning of the two into two threads.
Change-Id: I3173d3619e53d13a51a6e283eb320a618daacf21
When a line is double-clicked, or the highlight error is otherwise
changed, the redrawing of the highlighting was done by redrawing
the entire build console document. This was slow on very large
documents. Instead only redraw the line losing the highlight (if
any) and the line gaining the highlight.
In addition, as we only change the foreground colour to highlight,
avoid redrawing the background.
Change-Id: I5e652449715a588cb8702e0100a472d1f566e2a8