The serial plugin shows up in both the platform and native features.
It should only be in the native feature since the platform feature
includes it already.
Change-Id: I8150e72dcd76759f2b90e3b14421d5d670f7f513
For example, opening the CMake property page, there was a missing
message for the cmake-ui button.
Change-Id: I126fe1cb6e290edc289a2dade44500dd35ed1207
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
(cherry picked from commit 6cad124cf0)
This is a partial revert of e49517eb7c.
This revert prevents an otherwise unnecessary API version increment.
As e49517e added the correct version dependency from
org.eclipse.cdt.dsf.gdb to org.eclipse.cdt.core.native, which was the
true dependency, we don't have to increase the dependency on the
re-exported version within org.eclipse.cdt.core. Because
org.eclipse.cdt.core.native is a singleton and only the 5.10 version of
org.eclipse.cdt.core.native will satisfy the dependency where it is
needed in dsf-gdb, this solution guarantees correct wiring up.
Change-Id: I23b32480550fee33a4e156a91df12ac7720d8dc3
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
When a toolchain is selected along with its builder, the builder gets
matched to a “real builder” (ManagedBuildManager.getRealBuilder). If the
builder is abstract, the builder is not in the possible list of matches,
as implemented in Builder.getMatchKey. This causes
getCurrentBuilderCompatibilityInfo to return null which is not handled.
This patch changes the base LLVM builder to a non-abstract one, which
solves this specific NPE.
Also, in order to be more helpful to the user in case it happens to
another toolchain, a null check was added with an error message that the
builder is incompatible. Then at least, it is more clear that something
is wrong and the user can pick a different builder.
Change-Id: I4d26c568dfe6307b496719c10908a36933fd3ab8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
(cherry picked from commit 00b30bb03a)
This also fixes some ClassCastExceptions caused by types which
implemented ICPPASTInitializerClause but not ICPPEvaluationOwner.
Change-Id: Ie624865ebe476fe760dc28e02b6aef8a43b4c621
This patch fixes a variable overlay issue, that causes two overlays to
become mistakenly mangled together.
Change-Id: I3c95c400bb490c8e7efdd96d107e3af3f4fc7906
When using the "Alt-Enter" shortcut with a breakpoint selected, the
properties dialog that is created is missing some fields. This seems to
be caused by the fact that the dialog, when summoned in this way, is
created using a wrong context: an ICLineBreakpoint instead of the
expected CBreakpointContext. That context is then used to fetch
properties from the store, which fails.
This is a naive fix that attempts to work around this by creating a
proper context from the breakpoint.
Change-Id: I2b7c86965d09898dd1cd7eeb3c3f704bb2995e20
(cherry picked from commit 86189eeb86)
The path to GDB is set in the launch dialog, under the Debugger tab. If
the path to GDB contains one or more spaces, and is not within double
quotes, GDB will not be found and the launch will fail.
This patch improves the use cases around the "Browse" button, to select
GDB's path.
1) if the user clicks on the "Browse" button, the browse dialog will
open in the correct place, no matter the presence of space(s).
2) When GDB's path is selected with the "Browse" button, it's then set
in the "GDB debugger" field. This patch looks at the selected path and
adds surrounding double quotes if there is any space within, and strips
any double quotes if there are no spaces.
Change-Id: I202f574772965af3a491d449b9e9a97e8c61e2b0
(cherry picked from commit 7f6e7f8c9b)
Previously, the arguments shared the color of the template-name.
Now, the arguments get their own colors.
Change-Id: I27af4146717a19095f1ac22188eedb8a71d9466c
The set was moved to EvalUtil.getVariableValue() in bug 508254, but this
left some paths unprotected. This restores the set to
CPPVariable.getInitialValue() (while keeping the EvalUtil one too).
Change-Id: I4a579720f4bc23d41e50c484649a73c29698373d
Commit 6fc6c3c671 mistakenly removed the
two strings that were being used for the Run launch delegate. We
haven't noticed because we only have one Run launch delegate and
therefore its name does not end up being shown in most cases.
However, by going to Preferences->Run/Debug->Perspectives and then
expanding the C/C++ Application launch configuration type, the Run
delegate is shown with a missing string.
Change-Id: I2435097b0a13efd21ef3da01e2d4969d231a6f97
With GDB 7.12, it is possible to receive queries on the dedicated MI
channel. This channel is not accessible or shown to the user so if we
don't answer, GDB will wait forever.
This patch blindly answers 'y' to any query on the MI channel unless it
has already been answered automatically (which happens when we don't use
the full console).
Change-Id: I0e208fc3495ce6ba57b3e477661f47e50680fd88
(cherry picked from commit add2a14628)
Setting target-async ON in GDBJtagDSFFinalLaunchSequence_7_7 class
only when interfacing with the FullGDBConsole.
async mode is required when using the full GDB console in order
to process the suspend MI command "-exec-interrupt" while the target is
running.
Change-Id: I08c382550c6dd8a8567a66169495a9e490c35397
When checking whether gathering the build output from a
CBuildConfiguration, if a binary is a shared library and is an
ELF file, dig deeper and see if it has an INTERP section in the
program header. That tells us it's actually a PIE executable and
add it to the list.
As a rider to this bill, improve the error message when a Qt install
can't be found for a given toolchain/target.
Change-Id: I8fd0bf2d204e9425b02916d7b17f4309a5ad9dd5
