The position of namespaces didn't take into account because the
declaration doesn't exist yet when we use this kind of refactoring,
so the find method of MethodDefinitionInsertLocationFinder didn't
look for namespaces.
Change-Id: I839194879c41f86653c837ca83a306ea1840c1d0
Some heuristics in skipToStatementStart require knowledge of previous
token. It is initialized with value from a fToken, but it current value
may be invalid because looksLikeMethodDecl changes fPossition value
without adjusting a fToken. Using invalid value may lead to false
triggering of heuristics. Restore fToken value when change fPossition in
looksLikeMethodDecl to prevent this.
Change-Id: If0c2c0577c89a983e1479587409f293c3d0db7be
Signed-off-by: Andrey Mozzhuhin <amozzhuhin@yandex.ru>
A function call may be mistakenly interpreted in looksLikeMethodDecl()
as a method declaration. This was due to simplified processing of
functions with a scope qualifiers in the name.
Now methods with a scope qualifier are handled similarly to methods
without them.
Change-Id: Id3075d3387fdf9c4ae2d0dffa6cdf923fd1ef9d5
Signed-off-by: Andrey Mozzhuhin <amozzhuhin@yandex.ru>
Scanning of double char tokens (::, >>, >=, <<, <=, ->) is broken in
nextToken(). In each case, peekNextChar() was used to get second
character, but scanner position was already on second char and
peekPreviousChar() need to be used.
Change-Id: Ibd447c7cde8783e8ffe547d5f9bc09d11c1c60a7
Signed-off-by: Andrey Mozzhuhin <amozzhuhin@yandex.ru>
Straightforward conversion. Still usages left that need deeper
investigation how to be done proper.
Some long time commented code removed as java formatter breaks trailing
whitespaces on save.
Change-Id: If74259bed5735b0d4cc98fc2cfa609c9c53c80c9
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
If the correct namespace existed before the refactoring in the
translation unit, refactoring process just ignored it.
Change-Id: I9d6bd301807bb2d3f83f74ef772395d3470cf8bd
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
If an enum, a struct or a class is defined inside a class, the
implementation must qualify the declaration specifier.
Change-Id: I1e9450c7b165a25c4a745c50fe2e0c06e28775d0
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Part 2 (please refer to the Bug 559193 regarding the reasons to rework):
- Doxygen option read-only API for clients
- Doxygen option storage API for configuration UI
- OSGi component for Doxygen API implementation
Change-Id: Ia97ade397f1040087898aeb3b50872473d3c0631
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
The implementation of methods with parameter declaration or with
template template parameters didn't work.
Change-Id: I783dedc5ffecd6721293d52f13548fd9e73999bc
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Reworked UI code to its natural contract.
Switched java 8 to compact the code
Encapsulated scope inside the DoxygenPreferences
Change-Id: I534b8d4f7c2d6e7674b132a10ef3514e61f2c1ed
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Choice is one of:
Kichwa Coders Ltd
Kichwa Coders Canada Inc.
depending if contributed by UK or Canadian company
Change-Id: I5c9fb96ea6abf97858a6896911a71fa68b8400b1
Support optional template type specification of return type in method
declaration deduction.
Change-Id: Ibaa5d5128faefb0b95534918ba9980bd8449b851
Signed-off-by: Andrey Mozzhuhin <amozzhuhin@yandex.ru>
Instead of dropping single character prefixes in getter/setter name
generation,
we just drop the class field prefix as defined in the coding style.
Change-Id: I3c3853b1b0f675ad1802b1ebbddd68dc8c0c5b33
Signed-off-by: Hannes Vogt <hannes@havogt.de>
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
When at the same time never join wrapped lines and next line
for opening function brace were selected, two tabs were added.
Change-Id: I90f606bf7f8b7bb7e83f3ae85d7cbb9cd0146b97
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Add missing ; to test case.
Change-Id: If0224c4fc3580cbe527efe0d3a5739896a000d7e
Signed-off-by: Felix Morgner <fmorgner@hsr.ch>
Signed-off-by: Thomas Corbat <tcorbat@hsr.ch>
Methods weren't added if the virtual methods were in a base
template class.
Change-Id: I34b05eeb1e7dc5ce83944a642461eca521764967
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
The testLeakingInstanceAfterClose test relied on some weird
behaviour of an earlier test (testScalabilityDialogNotDismissedInadvertently_417909)
which had the effect of opening the editor window without the
welcome screen. This change makes that explicit and adds a little
bit of logging to identify why the testLeakingInstanceAfterClose
test may sometimes fail.
I have also increased the maximum time allowed before the test timesout.
Change-Id: I3433ccf1fc02cff76eeb278d05fee082157ca49c
Rules used:
1) Default is right alignment to be compliant with built-in formatter
rules;
2) Pointer with declarator without name will be always left alignment
unless there's a nested declarator;
3) Return value of methods/functions is always left alignment;
4) If left alignment is selected, if space after comma is selected too
for a declaration list, space is always forced after the comma.
Change-Id: I82d5ad130e665e5357644cc59655a558f3fb732f
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
Local scanner was peeking tokens from inactive regions confusing
the formatter.
Change-Id: I5975ec1042474be84b897e047a1e59cfc8bfa083
Signed-off-by: Marco Stornelli <marco.stornelli@gmail.com>
